Builds fine.
Details
Details
Diff Detail
Diff Detail
- Repository
- R95 PIM: Common Support
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Are you absolutely sure? It just removes deps that aren't used at all, and with the remaining time to RC we are safe to catch any unintended fallout imo.
src/pimcommon/CMakeLists.txt | ||
---|---|---|
197 ↗ | (On Diff #17080) | QIcon is part of QtGui, but indeed KIconLoader is used here so I'm adding it back. It probably just worked because being implicitly pulled in. |
Comment Actions
"Are you absolutely sure? It just removes deps that aren't used at all, and with the remaining time to RC we are safe to catch any unintended fallout imo."
yep master please.
Thanks.