Differential D6859

Cleanup unused dependencies
ClosedPublic
Actions

Authored by asturmlechner on Jul 23 2017, 8:29 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Commits
R95:fbebfbe29d19: Cleanup unused dependencies
Test Plan

Builds fine.

Diff Detail

Repository
R95 PIM: Common Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asturmlechner created this revision.Jul 23 2017, 8:29 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 23 2017, 8:29 PM
mlaurent requested changes to this revision.Jul 24 2017, 7:31 AM
mlaurent added a subscriber: mlaurent.

Please change as master not 17.08 as you remove some dep/lib

CMakeLists.txt
49

We use IconThemes in pimcommon

src/pimcommon/CMakeLists.txt
197 ↗(On Diff #17080)

it seems wierd as when I grep QIcon:: I see a lot of items here.
For me we need to keep it.

This revision now requires changes to proceed.Jul 24 2017, 7:31 AM
asturmlechner added a comment.Jul 24 2017, 6:22 PM
In D6859#128081, @mlaurent wrote:

Please change as master not 17.08 as you remove some dep/lib

Are you absolutely sure? It just removes deps that aren't used at all, and with the remaining time to RC we are safe to catch any unintended fallout imo.

src/pimcommon/CMakeLists.txt
197 ↗(On Diff #17080)

QIcon is part of QtGui, but indeed KIconLoader is used here so I'm adding it back. It probably just worked because being implicitly pulled in.

asturmlechner updated this revision to Diff 17135.Jul 24 2017, 6:26 PM
asturmlechner edited edge metadata.

Re-added KF5IconThemes

asturmlechner marked 3 inline comments as done.Jul 24 2017, 6:28 PM
mlaurent added a comment.Jul 24 2017, 7:48 PM

"Are you absolutely sure? It just removes deps that aren't used at all, and with the remaining time to RC we are safe to catch any unintended fallout imo."
yep master please.
Thanks.

asturmlechner updated this revision to Diff 17144.Jul 24 2017, 8:45 PM

Switch to master

mlaurent accepted this revision.Jul 24 2017, 9:22 PM
This revision is now accepted and ready to land.Jul 24 2017, 9:22 PM
Closed by commit R95:fbebfbe29d19: Cleanup unused dependencies (authored by asturmlechner). · Explain WhyJul 25 2017, 5:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (7 lines)

Diff 17159

View Options

CMakeLists.txt

Loading...