Differential D6858

Fix replaceCaptures() to work with more than 9 captures
ClosedPublic
Actions

Authored by dhaumann on Jul 23 2017, 5:29 PM.

Details

Reviewers
vkrause
Commits
R216:1010ce8b7e7a: Fix replaceCaptures() to work with more than 9 captures
Summary

Currently, the for loop iterates from 1...n, which is an issue, if n > 9.

Luckily, this so far was never an issue, since we typically have only one or two captures in dynamic context rules.

Additionally, the helper function to escape the regexp is removed in favor of QRegularExpression::escape().

Test Plan

make test still works.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Jul 23 2017, 5:29 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 23 2017, 5:29 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
vkrause accepted this revision.Jul 23 2017, 9:55 PM
This revision is now accepted and ready to land.Jul 23 2017, 9:55 PM
Closed by commit R216:1010ce8b7e7a: Fix replaceCaptures() to work with more than 9 captures (authored by dhaumann). · Explain WhyJul 23 2017, 10:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/rule.cpp (11 lines)

Diff 17081

View Options

src/lib/rule.cpp

Loading...