Differential D6826

Remove KIO dependency
ClosedPublic
Actions

Authored by arojas on Jul 22 2017, 9:27 AM.

Details

Reviewers

wbauer

Commits

R357:d62859c95709: Remove unused KIO dependency

Summary

Remove unused KIO dependency and explicitely add kcompletion, which was previously pulled by KIO

Test Plan

Builds, works

Diff Detail

Repository

R357 KFloppy

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

arojas created this revision.Jul 22 2017, 9:27 AM

Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJul 22 2017, 9:27 AM

Hm, doesn't build here:

[ 28%] Building CXX object CMakeFiles/kfloppy.dir/floppy.cpp.o
In file included from /usr/include/kcompletion.h:26:0,
                 from /usr/include/kcombobox.h:27,
                 from /home/wolfi/projects/KFloppy/floppy.cpp:48:
/usr/include/kshortcut.h: In function 'uint qHash(const KShortcut&)':
/usr/include/kshortcut.h:248:34: error: call of overloaded 'qHash(int)' is ambiguous
     return qHash(key.primary()[0]) + qHash(key.primary()[1]);
                                  ^

In D6826#128634, @wbauer wrote:

Hm, doesn't build here:

[ 28%] Building CXX object CMakeFiles/kfloppy.dir/floppy.cpp.o
In file included from /usr/include/kcompletion.h:26:0,
                 from /usr/include/kcombobox.h:27,
                 from /home/wolfi/projects/KFloppy/floppy.cpp:48:
/usr/include/kshortcut.h: In function 'uint qHash(const KShortcut&)':
/usr/include/kshortcut.h:248:34: error: call of overloaded 'qHash(int)' is ambiguous
     return qHash(key.primary()[0]) + qHash(key.primary()[1]);
                                  ^

That doesn't look related to this change, does it build for you without the patch? Builds fine here with Qt 5.9.1, GCC 7.1.1

Sorry.
It's fine after I cleaned out the build directory...

Ship it!

wbauer accepted this revision.Jul 25 2017, 5:54 AM

This revision is now accepted and ready to land.Jul 25 2017, 5:54 AM

Closed by commit R357:d62859c95709: Remove unused KIO dependency (authored by arojas). · Explain WhyJul 25 2017, 4:59 PM

This revision was automatically updated to reflect the committed changes.