Differential D6817

Fix crash based on "random" destruction order
ClosedPublic
Actions

Authored by cullmann on Jul 21 2017, 5:44 PM.

Details

Reviewers
kfunk
Group Reviewers
Frameworks
Commits
R39:d2d0c00c91dd: fix crash on view destruction because of non-deterministic cleanup of objects
Summary

See bug 381284, actionmenu might end up trying to delete objects already cleaned up by the parent as it has the same parent as the actions it manages.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cullmann created this revision.Jul 21 2017, 5:44 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 21 2017, 5:44 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
kfunk accepted this revision.Jul 21 2017, 7:07 PM

I can't reproduce the crash even without this patch anymore :\

I can't reproduce it *with* this patch either. The patch makes sense given my backtrace in the bug report => ship it!

This revision is now accepted and ready to land.Jul 21 2017, 7:07 PM
Closed by commit R39:d2d0c00c91dd: fix crash on view destruction because of non-deterministic cleanup of objects (authored by cullmann). · Explain WhyJul 21 2017, 9:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/view/kateview.h (10 lines)
Msrc/view/kateview.cpp (5 lines)

Diff 16987

View Options

src/view/kateview.h

Loading...
View Options

src/view/kateview.cpp

Loading...