Optional usage of documentationDirs from KDocTools
ClosedPublic
Actions

Authored by ltoscano on Jul 19 2017, 9:17 PM.

Details

Reviewers

aacid
cfeck

Commits

R125:140fa26afabd: Merge remote-tracking branch 'origin/Applications/17.08'
R125:bc0bc0f139cf: Optional usage of documentationDirs from KDocTools

Summary

Only if available. Unfortunately a bug in KDocTools prevents for
looking for its version, so use another the version of another core
library part of Frameworks.

Test Plan

The new code compiles without regression in functionalities:

the cache is created for toc entries
the documentation is found.

Diff Detail

Repository

R125 KHelpCenter

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ltoscano created this revision.Jul 19 2017, 9:17 PM

Restricted Application added a project: Documentation. · View Herald TranscriptJul 19 2017, 9:17 PM

Restricted Application added a subscriber: Documentation. · View Herald Transcript

Targeted for Applications/17.08. I think this is not a breakage of the dependency freeze because the minimum required version is not changed, but posting here for official approval.

aacid accepted this revision.Jul 24 2017, 10:38 AM

This revision is now accepted and ready to land.Jul 24 2017, 10:38 AM

Closed by commit R125:bc0bc0f139cf: Optional usage of documentationDirs from KDocTools (authored by ltoscano). · Explain WhyJul 24 2017, 10:46 AM

This revision was automatically updated to reflect the committed changes.

Which is right?
KF5 version > 5.36.0
KF5 version >= 5.36.0

This revision is now accepted and ready to land.Aug 4 2017, 10:13 AM

Ah, it was already fixed, sorry for the noise.