Differential D6777

Port to KStandardAction::RenameFile
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 19 2017, 8:19 AM.

Details

Reviewers
dfaure
Group Reviewers
Dolphin
Commits
R318:5481709016a5: Port to KStandardAction::RenameFile
Summary

It was introduced in kconfig(widgets) 5.25. Using the standard action
results in less code and no need to hardcode the F2 shortcut.

Test Plan
  • Change shortcut in System Settings -> Shortcuts -> Standard Shortcuts
  • Make sure the new shortcut is used by dolphin.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a subscriber: Konqueror. · View Herald TranscriptJul 19 2017, 8:19 AM
elvisangelaccio added a dependency: D6774: Fix labels of DeleteFile/RenameFile actions.Jul 19 2017, 8:20 AM
elvisangelaccio retitled this revision from Port to KStandardAction::MoveToTrash to Port to KStandardAction::RenameFile.
elvisangelaccio updated this revision to Diff 16909.Jul 19 2017, 9:16 AM
  • Bump kpartgui versions
dfaure accepted this revision.Jul 21 2017, 3:50 PM
This revision is now accepted and ready to land.Jul 21 2017, 3:50 PM
Closed by commit R318:5481709016a5: Port to KStandardAction::RenameFile (authored by elvisangelaccio). · Explain WhyAug 9 2017, 9:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17946

View Options

src/dolphincontextmenu.cpp

Loading...
View Options

src/dolphinmainwindow.cpp

Loading...
View Options

src/dolphinpart.cpp

Loading...
View Options

src/dolphinpart.rc

Loading...
View Options

src/dolphinui.rc

Loading...
View Options

src/views/dolphinviewactionhandler.cpp

Loading...