Differential D6735

[platforms/x11] Quit the OpenGL Freeze protection thread on shutdown
ClosedPublic
Actions

Authored by graesslin on Jul 16 2017, 4:04 PM.

Details

Reviewers
mart
Group Reviewers
KWin
Plasma
Commits
R108:06a558e3de65: [platforms/x11] Quit the OpenGL Freeze protection thread on shutdown
Summary

Weird NVIDIA behavior fixup part 2. Now that we do no longer freeze when
NVIDIA decides to create an OpenGL error on startup
(aefb5f4dd9d41aa7377d56ece203089c73aefe07), we experience a new issue.
KWin is terminating (no idea why, [1]) and at the same time the OpenGL freeze
protection thread is still running. So far we did not terminate the
thread on shutdown and thus we hit an abort in Qt.

This change ensures that we properly terminate the thread on shutdown.

[1] My current theory is that games terminate KWin, common pattern of
bug reports is "steam".

BUG: 382283
FIXED-IN: 5.10.4

Test Plan

Tortured KWin by making sure I go through the code path,
saw the abort without the patch, no more abort with the patch

Diff Detail

Repository
R108 KWin
Branch
quit-opengl-freeze-protection-thread-5.10
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Jul 16 2017, 4:04 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 16 2017, 4:04 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Jul 17 2017, 12:08 PM
This revision is now accepted and ready to land.Jul 17 2017, 12:08 PM
Closed by commit R108:06a558e3de65: [platforms/x11] Quit the OpenGL Freeze protection thread on shutdown (authored by graesslin). · Explain WhyJul 17 2017, 2:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16777

View Options

plugins/platforms/x11/standalone/x11_platform.cpp

Loading...