[aurorae] Add support for shaded windows
ClosedPublic
Actions

Authored by graesslin on Jul 15 2017, 5:03 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:bf0e0f071ceb: [aurorae] Add support for shaded windows

Summary

Aurorae did not render correctly. This change addresses the problem for
both maximized and restored windows.

BUG: 373319
FIXED-IN: 5.10.4

Test Plan

shaded windows with Plastik and SVG based theme

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: KWin. · View Herald TranscriptJul 15 2017, 5:03 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

Unfortunately there are still themes which cause glitches.

New approach to the problem

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJul 16 2017, 2:01 PM

cfeck added inline comments.

plugins/kdecorations/aurorae/src/aurorae.cpp
408	Do you remember why the other connection needed to be queued?

plugins/kdecorations/aurorae/src/aurorae.cpp
408	Yes, when maximizing it can happen that the deco gets destroyed. It would act like a delete this without the queued connection. With shade this cannot happen, so no need to queue.

This revision is now accepted and ready to land.Jul 17 2017, 4:40 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			plugins/kdecorations/aurorae/src/aurorae.cpp (2 lines)
M			plugins/kdecorations/aurorae/src/qml/Decoration.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16748	47f414b		Jul 15 2017, 5:03 PM	★	★
Diff 2	16774	47f414b	New approach to the problem	Jul 16 2017, 2:01 PM	★	★
Diff 3	16825	139b4dc	R108:bf0e0f071cebf9238669ce4352f29cc3f061edcc	Jul 17 2017, 2:51 PM	★	★