[aurorae] Add support for shaded windows
ClosedPublic

Authored by graesslin on Jul 15 2017, 5:03 PM.

Details

Summary

Aurorae did not render correctly. This change addresses the problem for
both maximized and restored windows.

BUG: 373319
FIXED-IN: 5.10.4

Test Plan

shaded windows with Plastik and SVG based theme

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Jul 15 2017, 5:03 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 15 2017, 5:03 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin planned changes to this revision.Jul 15 2017, 7:47 PM

Unfortunately there are still themes which cause glitches.

graesslin updated this revision to Diff 16774.Jul 16 2017, 2:01 PM

New approach to the problem

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJul 16 2017, 2:01 PM
cfeck added a subscriber: cfeck.Jul 17 2017, 4:05 AM
cfeck added inline comments.
plugins/kdecorations/aurorae/src/aurorae.cpp
408

Do you remember why the other connection needed to be queued?

graesslin added inline comments.Jul 17 2017, 4:27 AM
plugins/kdecorations/aurorae/src/aurorae.cpp
408

Yes, when maximizing it can happen that the deco gets destroyed. It would act like a delete this without the queued connection. With shade this cannot happen, so no need to queue.

cfeck accepted this revision.Jul 17 2017, 4:40 AM
This revision is now accepted and ready to land.Jul 17 2017, 4:40 AM
This revision was automatically updated to reflect the committed changes.