Differential D6711

Check for HUP/ERR/NVAL conditions on stdin
ClosedPublic
Actions

Authored by fvogt on Jul 15 2017, 12:05 PM.

Details

Reviewers
broulik
davidedmundson
Group Reviewers
Plasma
Commits
R856:4c2a3b168036: Check for HUP/ERR/NVAL conditions on stdin
Summary

While Qt's event loop checks for POLLHUP, it
treats it exactly like POLLIN and it's not possible
to retrieve that information from Qt. So in the
Connection read handler it needs to be checked for
again.

Test Plan

Before this patch plasma-browser-integration-host
consumed 100% CPU after exiting the browser, 100% reproducible.
Now it quits gracefully.

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Jul 15 2017, 12:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 15 2017, 12:05 PM
fvogt updated this revision to Diff 16856.Jul 18 2017, 8:34 AM

Use QCoreApplication, add BUG ref

broulik accepted this revision.Jul 18 2017, 8:36 AM
This revision is now accepted and ready to land.Jul 18 2017, 8:36 AM
Closed by commit R856:4c2a3b168036: Check for HUP/ERR/NVAL conditions on stdin (authored by fvogt). · Explain WhyJul 18 2017, 8:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhost/connection.cpp (19 lines)

Diff 16857

View Options

host/connection.cpp

Loading...