Differential D6704

Fix tabsrunner DBus reply parsing
ClosedPublic
Actions

Authored by fvogt on Jul 14 2017, 5:53 PM.

Details

Reviewers
broulik
davidedmundson
Group Reviewers
Plasma
Commits
R856:cfc45b00fb30: Fix tabsrunner DBus reply parsing
Summary

The TODO comment in the code turned out to have fixed itself,
so the code needed adjustment. As QList<QVariantHash>
(which is actually a QList<QHash<QString, QVariant>>) is apparently
not a demarshall target, a QVariant is used as intermediate step.

Test Plan

Installed, tabs listed.

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Jul 14 2017, 5:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 14 2017, 5:53 PM
davidedmundson accepted this revision.Jul 14 2017, 6:59 PM
This revision is now accepted and ready to land.Jul 14 2017, 6:59 PM
Closed by commit R856:cfc45b00fb30: Fix tabsrunner DBus reply parsing (authored by fvogt). · Explain WhyJul 14 2017, 7:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtabsrunner/tabsrunner.cpp (11 lines)

Diff 16722

View Options

tabsrunner/tabsrunner.cpp

Loading...