[server] Send keyboard leave when client destroys the focused surface
ClosedPublic
Actions

Authored by graesslin on Jul 13 2017, 3:49 PM.

Details

Reviewers

Group Reviewers

Frameworks
Plasma

Commits

R127:98e5d269a110: [server] Send keyboard leave when client destroys the focused surface

Summary

This is a change inspired by https://bugreports.qt.io/browse/QTBUG-61930.
When Qt closes a window due to a key press event it starts to repeat the
event as KWayland does not send a keyboard leave event. Weston on the
other hand does send out the keyboard leave. In my opinion it doesn't
make much sense to send out the keyboard leave in this situation and in
my opinion that is a client bug, but if it makes clients happy we can
send them the keyboard leave. Similar this should be done for pointer,
touch, etc.

BUG: 382280

Test Plan

Run the example added to the Qt bug and it worked fine

Diff Detail

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Jul 13 2017, 3:49 PM

Restricted Application added projects: Plasma on Wayland, Frameworks. · View Herald TranscriptJul 13 2017, 3:49 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Causes crash in KWayaland when closing a window.

Add nullptr check to prevent crash

Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptJul 15 2017, 7:03 PM

davidedmundson accepted this revision.Jul 15 2017, 7:09 PM

This revision is now accepted and ready to land.Jul 15 2017, 7:09 PM

Closed by commit R127:98e5d269a110: [server] Send keyboard leave when client destroys the focused surface (authored by graesslin). · Explain WhyJul 16 2017, 2:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/client/test_wayland_seat.cpp (3 lines)
M			src/server/keyboard_interface.cpp (5 lines)
M			src/server/resource.h (10 lines)
M			src/server/resource.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16661	80bc611		Jul 13 2017, 3:49 PM	★	★
Diff 2	16755	80bc611	Add nullptr check to prevent crash	Jul 15 2017, 7:03 PM	★	★
Diff 3	16775	80bc611	R127:98e5d269a110dca9cae1e4ed2bb3051f02a69bff	Jul 16 2017, 2:25 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
e3b4b5ae08a0	17ad0e7ce914	80bc61133a80	Martin Flöser	[server] Send keyboard leave when client destroys the focused surface (Show More…)	Jul 13 2017, 3:45 PM