Use return typehints in typebuilder for PHP language

Authored by mtijink on Jul 13 2017, 1:35 PM.



The return typehints are now used for function signatures. I also inlined TypeBuilder::openFunctionType into TypeBuilder::visitClassStatement since it's only used there and it makes the code clearer in my opinion.

Diff Detail

R52 KDevelop: PHP Support
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
mtijink created this revision.Jul 13 2017, 1:35 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 13 2017, 1:35 PM
brauch added a subscriber: brauch.Jul 13 2017, 8:35 PM

Looks sensible to me but I'm not really familiar with the php support.

zhigalin accepted this revision.Jul 17 2017, 8:27 AM
zhigalin added a subscriber: zhigalin.

Good one, pushing it right now...

This revision is now accepted and ready to land.Jul 17 2017, 8:27 AM
This revision was automatically updated to reflect the committed changes.