Declare AppManager.js as pragma library
ClosedPublic

Authored by broulik on Jul 13 2017, 12:09 PM.

Details

Summary

It doesn't store any state but contains only functions.

Test Plan

Only one instance of this script is created in plasmashell.
Before, I would get at least 6 instances (from various Dialogs that were created for instance).

(This file could get some cleanup, sceneX and sceneY can be achieved by doing mapToItem(null))

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 13 2017, 12:09 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJul 13 2017, 12:09 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jul 13 2017, 12:19 PM
davidedmundson added a subscriber: davidedmundson.

Before, I would get at least 6 instances (from various Dialogs that were created for instance).

I doubt it, no-one uses that. Probably TabBars.

In any case, I wouldn't spend /too/ long optimising QQC2 stuff, we are moving from it.

This revision is now accepted and ready to land.Jul 13 2017, 12:19 PM
This revision was automatically updated to reflect the committed changes.