Differential D6640

Treat device names as plaintext, not rich text
ClosedPublic
Actions

Authored by fvogt on Jul 12 2017, 8:59 AM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R224:5641d818dc68: Treat device names as plaintext, not rich text
Summary

Notifications, QML Text and QLabel accept a HTML subset,
which does not make sense for device names.

BUG: 382243

Test Plan

Sent a pair request and accepted it, device name
now shown as plain text everywhere.

Diff Detail

Repository
R224 KDE Connect
Branch
1.x
Lint
No Linters Available
Unit
No Unit Test Coverage
fvogt created this revision.Jul 12 2017, 8:59 AM
albertvaka accepted this revision.Jul 12 2017, 9:33 AM
This revision is now accepted and ready to land.Jul 12 2017, 9:33 AM
Closed by commit R224:5641d818dc68: Treat device names as plaintext, not rich text (authored by fvogt). · Explain WhyJul 12 2017, 9:34 AM
This revision was automatically updated to reflect the committed changes.
albertvaka added a comment.Jul 12 2017, 9:37 AM

Thanks Fabian! 😄

Revision Contents
Changeset List

Diff 16549

View Options

daemon/kdeconnectd.cpp

Loading...
View Options

kcm/kcm.ui

Loading...
View Options

plasmoid/package/contents/ui/DeviceDelegate.qml

Loading...