Complete de"qobject"ing KisOpenGLImageTextures
ClosedPublic
Actions

Authored by kossebau on Dec 16 2015, 3:14 AM.

Details

Reviewers

dkazakov
rempt

Commits

R37:c526e2648ddc: Complete de"qobject"ing KisOpenGLImageTextures

Summary

KisOpenGLImageTextures has no signals, so the only purpose of
disconnectCurrentCanvas() is a noop.
And it's two slots are nowhere used as slots, but only called directly.

Kept the names of the former slots for consistency with KisPrescaledProjection
as used in QPainter canvas

Diff Detail

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau updated this revision to Diff 1534.Dec 16 2015, 3:14 AM

kossebau retitled this revision from to Complete de"qobject"ing KisOpenGLImageTextures.

kossebau updated this object.

kossebau edited the test plan for this revision. (Show Details)

kossebau added reviewers: rempt, dkazakov.

Maybe it's also time to fold KisAbstractCanvasWidget and KisCanvasWidgetBase together again?

This revision is now accepted and ready to land.Dec 16 2015, 7:28 AM

Looks perfect to land! :)

Closed by commit R37:c526e2648ddc: Complete de"qobject"ing KisOpenGLImageTextures (authored by kossebau). · Explain WhyDec 16 2015, 1:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			krita/ui/canvas/kis_abstract_canvas_widget.h (3 lines)
M			krita/ui/canvas/kis_canvas2.h (1 line)
M			krita/ui/canvas/kis_canvas2.cpp (6 lines)
M			krita/ui/canvas/kis_qpainter_canvas.h (1 line)
M			krita/ui/canvas/kis_qpainter_canvas.cpp (3 lines)
M			krita/ui/opengl/kis_opengl_canvas2.h (1 line)
M			krita/ui/opengl/kis_opengl_canvas2.cpp (8 lines)
M			krita/ui/opengl/kis_opengl_image_textures.h (7 lines)