Differential D6609

[Kickoff] Allow sorting favorites
AbandonedPublic
Actions

Authored by broulik on Jul 10 2017, 1:31 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
VDG
Summary

This brings back the ability to manually sort favorites alphabetically.

BUG: 357125
FIXED-IN: 5.11.0

Test Plan

Needs D6608 or else it may crash with kiosk restrictions

  • Sorting ascending and descending works
  • Sort order respects whether apps are shown by description or by name
  • Verified that menu does not show up with fully locked desktop (where we disallow changing favorites)
  • Verified that favorites are persisted after sorting them

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 10 2017, 1:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 10 2017, 1:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jul 10 2017, 11:38 PM
This revision is now accepted and ready to land.Jul 10 2017, 11:38 PM
hein added a subscriber: hein.Jul 11 2017, 5:43 AM

Please don't commit this. It conflicts with D3805.

broulik abandoned this revision.Feb 15 2018, 12:50 PM

Probably needs to be completely redone with activities-powered favorites

Revision Contents
Changeset List

Diff 16451

View Options

applets/kicker/plugin/favoritesmodel.h

Loading...
View Options

applets/kicker/plugin/favoritesmodel.cpp

Loading...
View Options

applets/kickoff/package/contents/ui/FavoritesView.qml

Loading...