Home
Phabricator
Search
Log In
Differential
D6586
Remove unneeed code and clean up some logic on axisControl
Closed
Public
Actions
Authored by
rizzitello
on Jul 9 2017, 4:54 PM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Edit Tasks
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
None
Subscribers
Atelier: AtCore
Details
Reviewers
patrickelectric
Commits
R232:c4274db9e862: Remove unneeed code and clean up some logic
Diff Detail
Repository
R232 AtCore
Branch
fixAxisWidget
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello
created this revision.
Jul 9 2017, 4:54 PM
rizzitello
added a reviewer:
patrickelectric
.
Jul 9 2017, 4:54 PM
rizzitello
added a subscriber:
Atelier: AtCore
.
patrickelectric
requested changes to this revision.
Jul 9 2017, 4:56 PM
patrickelectric
added inline comments.
testclient/widgets/axiscontrol.cpp
181
ifndef and else are equals.
This revision now requires changes to proceed.
Jul 9 2017, 4:56 PM
rizzitello
updated this revision to
Diff 16396
.
Jul 9 2017, 4:59 PM
rizzitello
edited edge metadata.
Comment Actions
remove duplicate width code for z label
rizzitello
updated this revision to
Diff 16397
.
Jul 9 2017, 5:01 PM
Comment Actions
remove commented code
patrickelectric
accepted this revision.
Jul 9 2017, 5:01 PM
Comment Actions
much better, tys.
This revision is now accepted and ready to land.
Jul 9 2017, 5:01 PM
Closed by commit
R232:c4274db9e862: Remove unneeed code and clean up some logic
(authored by
rizzitello
).
·
Explain Why
Jul 9 2017, 5:09 PM
This revision was automatically updated to reflect the committed changes.