Differential D6586

Remove unneeed code and clean up some logic on axisControl
ClosedPublic
Actions

Authored by rizzitello on Jul 9 2017, 4:54 PM.

Details

Reviewers
patrickelectric
Commits
R232:c4274db9e862: Remove unneeed code and clean up some logic

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello created this revision.Jul 9 2017, 4:54 PM
patrickelectric requested changes to this revision.Jul 9 2017, 4:56 PM
patrickelectric added inline comments.
testclient/widgets/axiscontrol.cpp
177

ifndef and else are equals.

This revision now requires changes to proceed.Jul 9 2017, 4:56 PM
rizzitello updated this revision to Diff 16396.Jul 9 2017, 4:59 PM
rizzitello edited edge metadata.
  • remove duplicate width code for z label
rizzitello updated this revision to Diff 16397.Jul 9 2017, 5:01 PM
  • remove commented code
patrickelectric accepted this revision.Jul 9 2017, 5:01 PM

much better, tys.

This revision is now accepted and ready to land.Jul 9 2017, 5:01 PM
Closed by commit R232:c4274db9e862: Remove unneeed code and clean up some logic (authored by rizzitello). · Explain WhyJul 9 2017, 5:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16399

View Options

testclient/widgets/axiscontrol.h

Loading...
View Options

testclient/widgets/axiscontrol.cpp

Loading...