Differential D6584

Update Axis Control widget
AbandonedPublic
Actions

Authored by rizzitello on Jul 9 2017, 4:10 PM.

Tags

None

Subscribers

Atelier: General Development

Details

Reviewers

laysrodrigues
patrickelectric
tcanabrava

Summary

Solve T6424

Diff Detail

Repository

Branch

updateAxisControl

Lint

No Linters Available

Unit

No Unit Test Coverage

rizzitello created this revision.Jul 9 2017, 4:10 PM

rizzitello retitled this revision from Update Axis Control widget T6424 to Update Axis Control widget.Jul 9 2017, 4:10 PM

rizzitello edited the summary of this revision. (Show Details)

rizzitello added reviewers: laysrodrigues, patrickelectric, tcanabrava.

rizzitello mentioned this in T6424: Improve PrinterAxis Thing.

rizzitello added a subscriber: Atelier: General Development.

patrickelectric requested changes to this revision.Jul 9 2017, 4:21 PM

patrickelectric added inline comments.

src/widgets/axiscontrol.cpp
100	`== abs(value)`
177	you can remove all this with this logic: `lb->setY(item->y() + value/std::abs(value)*lb->boundingRect().height() / fontMetrics().xHeight());`
src/widgets/axiscontrol.h
74	nullptr

This revision now requires changes to proceed.Jul 9 2017, 4:21 PM

patrickelectric added inline comments.Jul 9 2017, 4:48 PM

src/widgets/axiscontrol.cpp
172–178	if and else are equals.

Newest axiscontrol

rizzitello marked 4 inline comments as done.Jul 9 2017, 5:08 PM

Rebase

laysrodrigues accepted this revision.Jul 12 2017, 12:31 PM

Rebase to master

email address update

tcanabrava accepted this revision.Jul 18 2017, 8:53 PM

merged

Revision Contents
Changeset List

			Path	Packages
M			src/mainwindow.h (1 line)
M			src/mainwindow.cpp (8 lines)
M			src/mainwindow.ui (6 lines)
M			src/widgets/CMakeLists.txt (2 lines)
V			src/widgets/{axiscontrol.h ← printerhostpositionvisualcontroller.h} (24 lines)
V			src/widgets/{axiscontrol.cpp ← printerhostpositionvisualcontroller.cpp} (100 lines)
V			src/widgets/{printerhostpositionvisualcontroller.h → axiscontrol.h}
V			src/widgets/{printerhostpositionvisualcontroller.cpp → axiscontrol.cpp}

Diff 16895

src/mainwindow.h

Loading...

src/mainwindow.cpp

Loading...

src/mainwindow.ui

Loading...

src/widgets/CMakeLists.txt

Loading...

src/widgets/axiscontrol.h

Loading...

src/widgets/axiscontrol.cpp

Loading...

src/widgets/printerhostpositionvisualcontroller.h

Loading...

src/widgets/printerhostpositionvisualcontroller.cpp

Loading...