Differential D6581

Fix crash in KCMKeyboardWidget::populateWithCurrentXkbOptions on Wayland
ClosedPublic
Actions

Authored by graesslin on Jul 9 2017, 1:20 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:5cd48d672782: Fix crash in KCMKeyboardWidget::populateWithCurrentXkbOptions on Wayland
Summary

Prevents a call into X11 which will crash. This needs to be fixed
properly by defining a way to get the options from the Wayland
compositor.

Test Plan

Can open the KCM without crash

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Jul 9 2017, 1:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 9 2017, 1:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jul 9 2017, 3:14 PM
This revision is now accepted and ready to land.Jul 9 2017, 3:14 PM
Closed by commit R119:5cd48d672782: Fix crash in KCMKeyboardWidget::populateWithCurrentXkbOptions on Wayland (authored by graesslin). · Explain WhyJul 10 2017, 8:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16470

View Options

kcms/keyboard/kcm_keyboard_widget.cpp

Loading...