| dkazakov |
| Krita |
I am trying to reduce the copying and allocations made in getStabilizedPaintInfo by reusing the result KisPaintInformation object in the mixing function.
Initial profiling shows stabilizerPollAndPaint taking 30% less time, but it's not very accurate.
The code looks a bit messy but it does what it does. Any suggestions on making it better or alternative approaches? (I dislike the implicit pass-by-reference parameter.)
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
It might be a good idea to denote KisPaintInformation::mix() function from 'statis' member to a usual method. Then the signature would be quite obvious :)
| libs/image/brushengine/kis_paint_information.cc | ||
|---|---|---|
| 561 | I think I might have made a redundant heap allocation here... | |
Profiling results by drawing in circle continuously for 20s
Highlighted on the left is operator new(unsigned long long) and on the right are places calling it. (You can use https://demangler.com/ to demangle the names. Add an underscore before the name for it to work.)
The profiling result file is also attached, use Very Sleepy to open.
Original code:
New code:
(These are only results of one
Redid some profiling with VTune (it doesn't prevent Krita from updating the canvas like Very Sleepy did):
Original code:
New code (the other constructor takes too little time to be worth mentioning):
From these two particular samples, it appears the new code not only saves a lot of time (about 90% time saved from constructing KisPaintInformation), but it also enabled a bit better utilization of the second CPU core (not sure what operation it is though).
Hi, @alvinhochun!
The patch looks fine, except of the mixture of different interfaces in KisPaintInformation. Could you add a bit of TODO with comments to the old-style mix() calls, so that people would know that they should be refactored?
Please also state in the comment that "on windows malloc/free is very slow and fragments the memory", so people would know that it is a Windows-specific problem.
| libs/image/brushengine/kis_paint_information.h | ||
|---|---|---|
| 268 | Please add comments to the old-style functions that they are to be refactored :) | |