Allows to leverage FocusScope's activeFocus property to determin whether we the text field or formatting buttons have focus.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R114:300771464b5a: [Notes applet] Wrap in FocusScope
Clicked in text field, tabbed through the applet successfully; formatting buttons only hid when I clicked outside the applet.
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Well, it's a lot more compact. All the items that I explicitly checked in the previous code are inside the FocusScope now
Comment Actions
Yep, just wanted to check that I'd understood the goal of the patch.
applets/notes/package/contents/ui/main.qml | ||
---|---|---|
134 ↗ | (On Diff #16355) | you've added an extra margin to the bottom. |
applets/notes/package/contents/ui/main.qml | ||
---|---|---|
134 ↗ | (On Diff #16355) | That's the bottomMargin the fontButtons Row originally had. I moved all the margins to the FocusScope and then just anchored the items inside without. |