[Notes applet] Wrap in FocusScope
ClosedPublic
Actions

Authored by broulik on Jul 8 2017, 2:11 PM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

R114:300771464b5a: [Notes applet] Wrap in FocusScope

Summary

Allows to leverage FocusScope's activeFocus property to determin whether we the text field or formatting buttons have focus.

Test Plan

Clicked in text field, tabbed through the applet successfully; formatting buttons only hid when I clicked outside the applet.

Repository

R114 Plasma Addons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Is this any different from the current opacity binding?

Well, it's a lot more compact. All the items that I explicitly checked in the previous code are inside the FocusScope now

Yep, just wanted to check that I'd understood the goal of the patch.

applets/notes/package/contents/ui/main.qml
134	you've added an extra margin to the bottom.

This revision is now accepted and ready to land.Jul 8 2017, 2:23 PM

applets/notes/package/contents/ui/main.qml
134	That's the bottomMargin the fontButtons Row originally had. I moved all the margins to the FocusScope and then just anchored the items inside without.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/notes/package/contents/ui/main.qml (276 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16354			Jul 8 2017, 2:10 PM	★	★
Diff 2	16355			Jul 8 2017, 2:12 PM	★	★
Diff 3	16356	bb474d5	R114:300771464b5aab6b16eac728e702e830e4d0960c	Jul 8 2017, 2:27 PM	★	★