Differential D6563

Remove unnecessary EIGEN_MAKE_ALIGNED_OPERATOR_NEW
ClosedPublic
Actions

Authored by alvinhochun on Jul 8 2017, 9:17 AM.

Details

Reviewers
dkazakov
Group Reviewers
Krita
Commits
R37:93c2cc7c0450: Remove unnecessary EIGEN_MAKE_ALIGNED_OPERATOR_NEW
Summary

It is only needed if there are vectorized Eigen objects as member fields.

(Mentioned in D6522#122078)

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alvinhochun created this revision.Jul 8 2017, 9:17 AM
Restricted Application added a subscriber: woltherav. · View Herald TranscriptJul 8 2017, 9:17 AM
dkazakov accepted this revision.Jul 8 2017, 9:48 AM
dkazakov added a subscriber: dkazakov.

Looks correct as well! :)

This revision is now accepted and ready to land.Jul 8 2017, 9:48 AM
Closed by commit R37:93c2cc7c0450: Remove unnecessary EIGEN_MAKE_ALIGNED_OPERATOR_NEW (authored by alvinhochun). · Explain WhyJul 8 2017, 12:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16339

View Options

libs/image/brushengine/kis_paint_information.cc

Loading...
View Options

libs/ui/tool/kis_tool_freehand.h

Loading...
View Options

plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_distance.h

Loading...
View Options

plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_fade.h

Loading...
View Options

plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_time.h

Loading...