Differential D6547

Fix build with Qt 5.9.1 and clang
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 7 2017, 9:37 AM.

Details

Reviewers
kfunk
Group Reviewers
Frameworks
Commits
R249:97ce7535124a: Fix build with Qt 5.9.1 and clang
Summary

Qt 5.9.1 expands Q_REQUIRED_RESULT to the [[nodiscard]] attribute (see
commit d254d8c19 in qtbase). This breaks the build with clang compilers
because [[nodiscard]] cannot be used at the end of a function
declaration:

error: 'nodiscard' attribute cannot be applied to types

For the record, GCC just issues a 'attribute ignored' warning when
[[nodiscard]] is used at the end of a declaration.

Test Plan

ki18n now builds with clang + Qt 5.9.1

Diff Detail

Repository
R249 KI18n
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio created this revision.Jul 7 2017, 9:37 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 7 2017, 9:37 AM
elvisangelaccio edited the summary of this revision. (Show Details)Jul 7 2017, 9:38 AM
kfunk accepted this revision.Jul 7 2017, 10:37 AM
This revision is now accepted and ready to land.Jul 7 2017, 10:37 AM
Closed by commit R249:97ce7535124a: Fix build with Qt 5.9.1 and clang (authored by elvisangelaccio). · Explain WhyJul 8 2017, 4:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/klocalizedstring.h (72 lines)

Diff 16360

View Options

src/klocalizedstring.h

Loading...