Fix display of formatDuration with rounding.
ClosedPublic
Actions

Authored by davidedmundson on Jul 6 2017, 8:16 PM.

Details

Reviewers

Commits

Summary

When showing the time (1 hour 59.5 minutes) with seconds hidden we
want to show "2 hours 0 minutes" not "1 hour 60 minutes".

This is fixed by performing the rounding before we split the number of
miliseconds into component parts, rather than splitting and then
rounding.

BUG: 360681
BUG: 382069

Test Plan

Updated unit test

Repository

R244 KCoreAddons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

This revision is now accepted and ready to land.Jul 7 2017, 11:45 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/kformattest.cpp (20 lines)
M			src/lib/util/kformatprivate.cpp (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16271	1a80b87		Jul 6 2017, 8:16 PM	★	★
Diff 2	16300	1a80b87	R244:13675d6ab695ba3d1e621ae5493f66ee25e5091d	Jul 6 2017, 8:16 PM	★	★