Use CMAKE_INSTALL_BINDIR for dbus service generation
ClosedPublic

Authored by bkchr on Jul 5 2017, 6:45 PM.

Details

Summary

The old implementation used CMAKE_INSTALL_PREFIX for determining the installation directory. The target is installed by using KF5_INSTALL_TARGETS_DEFAULT_ARGS and that internally uses CMAKE_INSTALL_BINDIR. In my case I used a distribution (Nixos) where CMAKE_INSTALL_BINDIR is not a sub directory of CMAKE_INSTALL_PREFIX and thus Dbus could not find the kwallet5d executable.

Diff Detail

Repository
R311 KWallet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bkchr created this revision.Jul 5 2017, 6:45 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 5 2017, 6:45 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
apol accepted this revision.Jul 6 2017, 10:07 AM
This revision is now accepted and ready to land.Jul 6 2017, 10:07 AM
bkchr added a comment.Jul 6 2017, 10:48 AM

@apol do you will push this change for me? Or will this happen automatically? ^^

apol added a comment.Jul 6 2017, 12:30 PM
In D6519#122060, @bkchr wrote:

@apol do you will push this change for me? Or will this happen automatically? ^^

I can do that, can you tell me what e-mail to use?

bkchr added a comment.Jul 6 2017, 12:38 PM

Use git@kchr.de
Thank you :)

This revision was automatically updated to reflect the committed changes.