Fix external launch of executables with spaces in paths[windows]
ClosedPublic

Authored by geetamc on Jul 4 2017, 3:10 PM.

Details

Summary

Instead of first splitting the arguments, and replacing %exe and %workdir by their quoted values,
they are replaced first and split later which strips the command of \^" at beginning and end.

Test Plan

Executing in external terminal works fine after the patch:
-when executable path contains spaces (on both windows and linux.)
-when it does not contain any spaces.
before:


after:

External terminal command used was: cmd /c start "" call %exe

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
geetamc created this revision.Jul 4 2017, 3:10 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 4 2017, 3:10 PM
geetamc edited the summary of this revision. (Show Details)Jul 4 2017, 3:11 PM
geetamc edited the test plan for this revision. (Show Details)
brauch accepted this revision.Jul 4 2017, 4:20 PM
brauch added a subscriber: brauch.

Looks sensible to me.

This revision is now accepted and ready to land.Jul 4 2017, 4:20 PM
This revision was automatically updated to reflect the committed changes.