Differential D6493

Add KF5WindowSystem to link interface
ClosedPublic
Actions

Authored by asturmlechner on Jul 3 2017, 9:06 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:5033a104e226: Add KF5WindowSystem to link interface
Summary

Otherwise, reverse-dependencies are bugged
with finding KF5WindowSystem themselves.

Test Plan

Builds fine, plasma-sdk does not need to add KF5WindowSystem anymore.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asturmlechner created this revision.Jul 3 2017, 9:06 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 3 2017, 9:06 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
davidedmundson added a subscriber: davidedmundson.EditedJul 3 2017, 9:19 PM

You're right that there's a bug, but I think this solution has it backwards.

We don't use WindowSystem in public API, and it's PlasmaQuick/CmakeLists.txt that's wrong by putting it in public not the other way round.

See https://phabricator.kde.org/D6495

asturmlechner abandoned this revision.Jul 3 2017, 9:32 PM
davidedmundson added a comment.Jul 5 2017, 11:46 AM

Edit: I was wrong.

We do need your first change but not the second change to cmakelists.txt

asturmlechner updated this revision to Diff 16896.Jul 18 2017, 9:02 PM

Changed according to review

Restricted Application added a project: Plasma. · View Herald TranscriptJul 18 2017, 9:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jul 18 2017, 9:16 PM
This revision is now accepted and ready to land.Jul 18 2017, 9:16 PM
Closed by commit R242:5033a104e226: Add KF5WindowSystem to link interface (authored by asturmlechner). · Explain WhyJul 19 2017, 2:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MKF5PlasmaConfig.cmake.in (1 line)

Diff 16913

View Options

KF5PlasmaConfig.cmake.in

Loading...