Restore shortcut schemes editor
ClosedPublic
Actions

Authored by abrahams on Dec 10 2015, 4:28 AM.

Details

Reviewers

rempt

Group Reviewers

Krita

Commits

R37:440621b25a05: Restore shortcut schemes editor

Summary

Port shortcut scheme file search to KoResourcePaths

Also prettify the shortcut scheme options

Define behavior of custom shortcuts vs. shortcut schemes

kritashortcutsrc now contains only custom shortcuts. Shortcut schemes files are loaded separately and go in share/krita/shortcuts/

Add empty (for now) directory for shortcut schemes.

This directory is where the shortcut editor will look for scheme files.

Repository

R37 Krita

Branch

shortcut-schemes

Lint

No Linters Available

Unit

No Unit Test Coverage

abrahams retitled this revision from to Restore shortcut schemes editor.

abrahams updated this object.

abrahams edited the test plan for this revision. (Show Details)

abrahams added a reviewer: Krita.

If you also feel it's ready to land, please push to master. It looks good to me.

This revision is now accepted and ready to land.Dec 10 2015, 7:35 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			krita/CMakeLists.txt (3 lines)
M			krita/ui/KisPart.h (2 lines)
M			krita/ui/KisPart.cpp (12 lines)
M			libs/widgetutils/CMakeLists.txt (4 lines)
M			libs/widgetutils/kis_action_registry.h (20 lines)
M			libs/widgetutils/kis_action_registry.cpp (97 lines)
M			libs/widgetutils/xmlgui/KisShortcutsDialog.h (13 lines)
M			libs/widgetutils/xmlgui/KisShortcutsDialog.cpp (48 lines)
M			libs/widgetutils/xmlgui/KisShortcutsDialog_p.h (38 lines)
M			libs/widgetutils/xmlgui/KisShortcutsDialog_p.cpp (38 lines)
M			libs/widgetutils/xmlgui/KisShortcutsEditor.h (4 lines)
M			libs/widgetutils/xmlgui/KisShortcutsEditor.cpp (47 lines)
M			libs/widgetutils/xmlgui/KisShortcutsEditor_p.h (3 lines)
M			libs/widgetutils/xmlgui/KisShortcutsEditor_p.cpp (26 lines)
M			libs/widgetutils/xmlgui/kactioncollection.h (4 lines)
M			libs/widgetutils/xmlgui/kactioncollection.cpp (30 lines)
M			libs/widgetutils/xmlgui/kshortcutschemeseditor.cpp (86 lines)
M			libs/widgetutils/xmlgui/kshortcutschemeshelper.cpp (43 lines)
M			libs/widgetutils/xmlgui/kshortcutschemeshelper_p.h (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1495	6ee1f15		Dec 10 2015, 4:28 AM	★	★
Diff 2	1498	5221d23	Commit rKRITA440621b25a050931adbebe1600b91556a3795d08	Dec 10 2015, 1:14 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
94b07f678597	4e96890e5236	6b1a332ea852	Michael Abrahams	Add empty (for now) directory for shortcut schemes (Show More…)	Dec 10 2015, 4:08 AM
6b1a332ea852	9375a226b1a6	a70d80f7c4e4	Michael Abrahams	Define behavior of custom shortcuts vs. shortcut schemes (Show More…)	Dec 10 2015, 3:35 AM
a70d80f7c4e4	c08c6757a8a4	733daa7f5a42	Michael Abrahams	Restore changeShortcutScheme() (Show More…)	Dec 8 2015, 12:06 AM
733daa7f5a42	953e082c8d27	a46ec1d96469	Michael Abrahams	Update comments+indentation in KisShortcutsEditor	Dec 8 2015, 9:27 PM
a46ec1d96469	f326ddaefcb1	39b66398bb9a	Michael Abrahams	Port shortcut scheme file search to KoResourcePaths (Show More…)	Dec 7 2015, 11:51 PM
39b66398bb9a	aafc3fc5ce7d	6ee1f1581718	Michael Abrahams	Restore shortcut schemes editor	Dec 7 2015, 7:36 AM