Fix the reference to KDE (or remove them when not strictly needed).
Details
Details
The code still compiles.
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
... and few in-line questions for the reviewers.
| kcms/autostart/autostart.cpp | ||
|---|---|---|
| 75 ↗ | (On Diff #16097) | Should this be "Session" or "Plasma Session"? Aren't the settings changed here valid for all desktops which follow the XDG spec? |
| kcms/desktoppaths/globalpaths.cpp | ||
| 127 ↗ | (On Diff #16097) | I explicitly wrote "Plasma" because this setting seems to be Plasma-specific. Did I understand it correctly? |
| kcms/fonts/fonts.cpp | ||
| 680 ↗ | (On Diff #16097) | Remove references to kdmrc in the meantime. |
| kcms/autostart/autostart.cpp | ||
|---|---|---|
| 75 ↗ | (On Diff #16097) | Yes, it should be valid for all DEs (I'd vote for "Session" only then) |
| kcms/componentchooser/emailclientconfig_ui.ui | ||
| 12 ↗ | (On Diff #16097) | I'd keep the old one as well, just for a better discoverability |
| kcms/desktoppaths/globalpaths.cpp | ||
| 127 ↗ | (On Diff #16097) | Again, this should be desktop agnostic |
| kcms/componentchooser/emailclientconfig_ui.ui | ||
|---|---|---|
| 12 ↗ | (On Diff #16097) | Do you mean keep KDE somehow? But "KDE desktop" is exactly what should go away :) |