Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
ClosedPublic

Authored by ltoscano on Jul 2 2017, 1:07 PM.

Details

Summary

Fix the reference to KDE (or remove them when not strictly needed).

Test Plan

The code still compiles.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ltoscano created this revision.Jul 2 2017, 1:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 2 2017, 1:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

... and few in-line questions for the reviewers.

kcms/autostart/autostart.cpp
75

Should this be "Session" or "Plasma Session"? Aren't the settings changed here valid for all desktops which follow the XDG spec?

kcms/desktoppaths/globalpaths.cpp
127

I explicitly wrote "Plasma" because this setting seems to be Plasma-specific. Did I understand it correctly?

kcms/fonts/fonts.cpp
680

Remove references to kdmrc in the meantime.

lukas added a subscriber: lukas.Jul 3 2017, 8:24 AM
lukas added inline comments.Jul 3 2017, 8:46 AM
kcms/autostart/autostart.cpp
75

Yes, it should be valid for all DEs (I'd vote for "Session" only then)

kcms/componentchooser/emailclientconfig_ui.ui
12

I'd keep the old one as well, just for a better discoverability

kcms/desktoppaths/globalpaths.cpp
127

Again, this should be desktop agnostic

ltoscano added inline comments.Jul 3 2017, 10:00 AM
kcms/componentchooser/emailclientconfig_ui.ui
12

Do you mean keep KDE somehow? But "KDE desktop" is exactly what should go away :)

sebas added a subscriber: sebas.Jul 3 2017, 10:49 AM

Needs to smallish changes, then good to go in.

kcms/componentchooser/emailclientconfig_ui.ui
12

Yeah, exactly. The KDE should go away here.

kcms/desktoppaths/globalpaths.cpp
127

"whenever the session starts" is fine here.

ltoscano updated this revision to Diff 16149.Jul 3 2017, 8:49 PM

Remove a Plasma reference (generic session)

davidedmundson accepted this revision.Aug 7 2017, 10:39 AM
This revision is now accepted and ready to land.Aug 7 2017, 10:39 AM
This revision was automatically updated to reflect the committed changes.