position the shellsurface immediately
Needs RevisionPublic

Authored by mart on Jun 30 2017, 3:59 PM.

Details

Reviewers
graesslin
davidedmundson
Group Reviewers
Plasma
Summary

when the window gets moved, position the shellsurface immediately
rather than in an event: otherwise it's too late and having a moment
in which the geometry doesn't correspond with the actual surface
geometry, makes the panelcontroller window to stutter and tremble
while dragged around with wayland

Test Plan

dragging panel controller around on wayland is more deterministic,
tough it's kinda slow, while dragging it with the touchscreen instead
of a mouse or touchpad is as fast as expected, this may be worth
further investigation (a kwin issue?)

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Jun 30 2017, 3:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 30 2017, 3:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

otherwise it's too late

too late for what?

graesslin edited edge metadata.Jul 11 2017, 3:34 PM

What I don't like about it is that KWin will get and react on two events with one having invalid coordinates. We get an event for the change of x and at that point y might be invalid. KWin will position the window there and that can result in mess (e.g. all windows get resized because the maximize area changes).

Otherwise it's similar to what KWin does for it's own windows, though KWin doesn't create panels which is a huge difference.

So I would prefer a solution which only creates one setPosition event.

davidedmundson requested changes to this revision.Aug 28 2018, 10:41 AM

This seems outdated. It also doesn't seem to be an issue?
Possibly fixed by us having the extra roundtrip with the XDG shell configure

This revision now requires changes to proceed.Aug 28 2018, 10:41 AM