This allows the config UI to know when to enable the Apply button.
Currently we only do that when the shortcut or actions themselves change but not their configuration.
Details
Details
- Reviewers
mart - Group Reviewers
Plasma - Commits
- R120:3257f5f92373: [CurrentContainmentActionsModel] Add configurationChanged signal
Added a Connections to ConfigurationContainmentActions that triggers the config dialog's configurationChanged() and had the Apply button correctly enabled when changing a containment action's settings
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Lint Skipped - Unit
Unit Tests Skipped
| shell/currentcontainmentactionsmodel.cpp | ||
|---|---|---|
| 217 ↗ | (On Diff #16040) | Hmm I pass in "this" but it's nowhere guarded :/ |
| shell/currentcontainmentactionsmodel.cpp | ||
|---|---|---|
| 217 ↗ | (On Diff #16040) | yeah, it may crash.. whatever is in the 3rd param of the connect is the one you can not worry about, the other one may get dangling.. |
Comment Actions
Can you please upload patches with arc otherwise we don't get to expand the context.
Plugins have the lifespan of containment. (but could change as user toggles things)
ConfigDlg lasts till it's quit
This model is owned by the ContainmentConfigView.
So you're right to question that, it's a good catch.
But it's easily fixable, pass this a parent to configdlg - or just use two connect statements.