| aheinecke | |
| dvratil |
| KDE PIM: Kleopatra |
The comment part of OpenPGP user ids is nowadays seen as a misfeature.
There is no consensus about what kind of information to put there, and
worse, users may not be aware that this information is published as
part of the certificate.
Signed-off-by: Justus Winter <justus@gnupg.org>
aheinecke approves of the change.
| No Linters Available |
| No Unit Test Coverage |
Looks good, just please fix the QString issue and it's good to go.
| src/newcertificatewizard/newcertificatewizard.cpp | ||
|---|---|---|
| 1460 | Use QString() or just {} instead of "" | |
Looks good to me, too. Do you have push access or should I push this for you?
Please add
BUG: 354513
As a line in the commit message (see: https://bugs.kde.org/show_bug.cgi?id=354513 )
Andre Heinecke <noreply@phabricator.kde.org> writes:
Looks good to me, too. Do you have push access or should I push this for you?
Please push it on my behalf. I don't think that I have push access.
Please add BUG: 354513
Check.
As a line in the commit message (see: https://bugs.kde.org/show_bug.cgi?id=354513 )
Ah. Bugzilla. Now I know three places where bugs for kleopatra can be
filed >,<
Eww, arc did not update the message. Anyway, is this really the preferred way to submit patches to Kleopatra?
For Reviews, Yes. For minor things or once you are very comfortable with the codebase a direct push is also acceptable imo.
We should probably get you push access to KDE before I'm out for a longer time. Jochen or Dan could also push for you. I'll test/fix/push some other queued changes now and then this one.