Differential D6405

Use check_symbol_exists() to check if cfree() is available
AbandonedPublic
Actions

Authored by mwolff on Jun 27 2017, 11:39 AM.

Details

Reviewers
dvratil
Summary

On Fedora rawhide (glib 2.26-pre), cfree() is not available anymore at all. Let's use check_symbol_exists() to figure out whether cfree() is available at configure time and let CMake define HAVE_CFREE instead.

Test Plan

heaptrack compiles on Fedora rawhide

Diff Detail

Repository
R45 Heaptrack
Lint
Lint Skipped
Unit
Unit Tests Skipped
dvratil created this revision.Jun 27 2017, 11:39 AM
mwolff requested changes to this revision.Aug 27 2017, 8:35 PM
mwolff added inline comments.
CMakeLists.txt
79

please use the config.h.cmake file with a #cmakedefine instead

This revision now requires changes to proceed.Aug 27 2017, 8:35 PM
beischer added a subscriber: beischer.Aug 30 2017, 8:08 PM

I opened https://phabricator.kde.org/D7621 which includes the requested changes.

mwolff commandeered this revision.Aug 31 2017, 7:57 AM
mwolff edited reviewers, added: dvratil; removed: mwolff.

taking over to close

mwolff abandoned this revision.Aug 31 2017, 7:57 AM

abandoning since https://phabricator.kde.org/D7621 got landed

Revision Contents
Changeset List

Diff 15909

View Options

CMakeLists.txt

Loading...
View Options

src/track/heaptrack_inject.cpp

Loading...
View Options

src/track/heaptrack_preload.cpp

Loading...
View Options

tests/manual/test.cpp

Loading...