Use check_symbol_exists() to check if cfree() is available (v2)
ClosedPublic

Authored by beischer on Wed, Aug 30, 8:07 PM.

Details

Summary

This is a follow-up of https://phabricator.kde.org/D6405 including the requested changes. Thanks to Daniel Vratil for the initial work.

Test Plan

heaptrack compiles on Arch Linux x86_64 with glibc 2.26.

Diff Detail

Repository
R45 Heaptrack
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
beischer created this revision.Wed, Aug 30, 8:07 PM
beischer updated this revision to Diff 18985.Thu, Aug 31, 6:18 AM

Added link to bug 383889.

mwolff accepted this revision.Thu, Aug 31, 7:51 AM

thanks, I'll fix this up and merge this

src/util/config.h.cmake
34

you could use cmakedefine01 here and then #if ... in the c++ code, to ensure we don't typo anything (since #if defined(HAVE_CFRE) e.g. would compile but be wrong

This revision is now accepted and ready to land.Thu, Aug 31, 7:51 AM
This revision was automatically updated to reflect the committed changes.