psd check RESN_INFO size is not set to zero
ClosedPublic
Actions

Authored by markreid on Jun 26 2017, 11:12 PM.

Details

Reviewers

rempt
dkazakov

Group Reviewers

Krita

Commits

Summary

Hi,
This patch fixes a issue I'm having with some photoshop files that seem to have RESN_INFO set to 0, 0. I can supply samples if required

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

here is a psd file that has this behaviour

checkerboard2.0143.psd12 MBDownload

Sounds like a sensible thing to do -- are these psd files created with photoshop or another application?

This revision is now accepted and ready to land.Jun 27 2017, 8:46 AM

The patch looks ok from the code point of view. Do you have commit rights for pushing it into the repository, or we should push it for you?

Thanks for the review.
@rempt the files are initially created with imagemagick but then opened and saved with photoshop.

@dkazakov I don't have commit rights, if someone could push it for me that would be great.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			plugins/impex/psd/psd_loader.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15895			Jun 26 2017, 11:03 PM	★	★
Diff 2	15983	68457c3	R37:87784520235991e1d30ad0c501761c8ac7d1cf0b	Jun 29 2017, 9:28 AM	★	★