Search for kdelibs optionally
ClosedPublic

Authored by davidedmundson on Jun 26 2017, 3:50 PM.

Details

Summary

QtCurve uses it's own bespoke way of handling optional dependencies
whereby if something is not explicitly enabled it will optionally try to
find a library and update an enabled flag before unconditionally trying
to find the library again.

This currently existed for Qt4&5, but not kdelibs.

Diff Detail

Repository
R626 QtCurve
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jun 26 2017, 3:50 PM
rjvbb edited edge metadata.Jun 26 2017, 4:10 PM

Let me get this straight, the goal here is to check if the KDE4 libs are available when building the Qt4 subdir and the user did NOT request KDE support to be built explicitly?

So, when building for Qt4

  • user didn't ask anything:
    • if KDELibs are available: build KDE support, otherwise don't (and don't yell)
  • user asked for KDE support:
    • if KDELibs are available: build KDE support, otherwise raise an error
  • user asked for NO KDE support:
    • don't check for KDELibs

That's right.

It's what's done for Qt currently. Personally, I think it's somewhat over-engineered, but we should make the KDE finding match.

rjvbb added a comment.Jun 26 2017, 5:13 PM

we should make the KDE finding match.

I don't think there's any particular obligation for that, but personally I'd be fine too with an implementation where you need to request KDE support specifically (basically keeping only item 2 from my breakdown above) or where you'd have to disable it explicitly if you only want the "pure Qt" style. But that might break packaging...

yuyichao accepted this revision.Jun 26 2017, 10:15 PM
This revision is now accepted and ready to land.Jun 26 2017, 10:15 PM
This revision was automatically updated to reflect the committed changes.