Differential D6343

Add a check for whether the item isn't actually visible
ClosedPublic
Actions

Authored by apol on Jun 22 2017, 2:21 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:fd81e9f468bc: Add a check for whether the item isn't actually visible
Summary

if width or height is 0 we just get warnings such as:
QImage::scaled: Image is a null image

And in the end we're performing void operations that we could skip
altohether.

Test Plan

Now I can run KAlgebra without the warning

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Jun 22 2017, 2:21 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJun 22 2017, 2:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jun 30 2017, 10:03 AM
This revision is now accepted and ready to land.Jun 30 2017, 10:03 AM
Closed by commit R169:fd81e9f468bc: Add a check for whether the item isn't actually visible (authored by apol). · Explain WhyJun 30 2017, 10:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/desktopicon.cpp (67 lines)

Diff 15746

View Options

src/desktopicon.cpp

Loading...