Differential D6340

Fix incorrect error detection for missing knsrc files
ClosedPublic
Actions

Authored by leinir on Jun 22 2017, 12:48 PM.

Details

Reviewers
apol
Group Reviewers
KNewStuff
Commits
R304:eb2e65a882f0: Fix incorrect error detection for missing knsrc files
Summary

This fixes the error detection for knsrc files, which previously would report missing files only if the directory (or file) was unreadable by the user, and incorrectly describe the error.

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Jun 22 2017, 12:48 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 22 2017, 12:48 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
apol accepted this revision.Jun 22 2017, 1:06 PM
apol added a subscriber: apol.

+1 for proper error messages!

src/core/engine.cpp
130 ↗(On Diff #15742)

are you sure the endl is necessary?

This revision is now accepted and ready to land.Jun 22 2017, 1:06 PM
leinir marked an inline comment as done.Jun 23 2017, 10:48 AM
leinir added inline comments.
src/core/engine.cpp
130 ↗(On Diff #15742)

i am, in fact, reasonably certain it is not required - leftovers are fun, i'll get rid of that :)

Closed by commit R304:eb2e65a882f0: Fix incorrect error detection for missing knsrc files (authored by leinir). · Explain WhyJun 23 2017, 10:50 AM
This revision was automatically updated to reflect the committed changes.
leinir marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Msrc/core/engine.cpp (10 lines)

Diff 15781

View Options

src/core/engine.cpp

Loading...