Be explicit about special menu item roles, required to prevent menu items from missing on OSX
ClosedPublic
Actions

Authored by amccann on Dec 4 2015, 5:07 AM.

Details

Reviewers

mwolff
kfunk

Group Reviewers

KDevelop

Commits

Summary

Test Plan

Verify 'Configure Launches', 'Configure Selection', 'About Kdevelop Platform', 'quit' (session) menu items are present on OSX.

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

amccann retitled this revision from to Be explicit about special menu item roles, required to prevent menu items from missing on OSX.

amccann updated this object.

amccann edited the test plan for this revision. (Show Details)

Not sure if the comment on each line was necessary.

However, the need for this is entirely non-obvious.

Great work!

This revision is now accepted and ready to land.Dec 4 2015, 7:31 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			plugins/projectmanagerview/projectmanagerviewplugin.cpp (1 line)
M			shell/mainwindow_p.cpp (1 line)
M			shell/runcontroller.cpp (1 line)
M			shell/sessioncontroller.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1443	c3724fa		Dec 4 2015, 5:07 AM	★	★
Diff 2	1447	bcdd01a	Commit rKDEVPLATFORMc4511d65c167564d2db952539de30af08ebb2ab3	Dec 4 2015, 5:53 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
ae3e145a1a6e	df194ea834f1	c3724fae9a0d	Andrew McCann	Be explicit about special menu item roles, required to prevent menu items from… (Show More…)	Dec 3 2015, 8:47 PM