Differential D6203

Filetransfer Feedback
AbandonedPublic
Actions

Authored by nicolasfella on Jun 12 2017, 10:35 PM.

Details

Reviewers
None
Group Reviewers
KDE Connect
Summary

Filetransfers Desktop -> Phone now give Feedback via ACK-Packages. See korresponding Android-Patch

Diff Detail

Repository
R224 KDE Connect
Lint
Lint Skipped
Unit
Unit Tests Skipped
nicolasfella created this revision.Jun 12 2017, 10:35 PM
apol added a subscriber: apol.Jun 13 2017, 1:41 AM

What are you trying to achieve?

plugins/share/shareplugin.cpp
96

should be i18n("%1 was sent successfully" np.get(...))

nicolasfella updated this revision to Diff 15453.Jun 14 2017, 8:14 PM

Addressed comments. I want to give the user feedback when the filetransfer is finished. The user might want to know if the transfer was successful even when the phone is not reachable

apol added a comment.Jun 14 2017, 10:09 PM
In D6203#116461, @nicolasfella wrote:

Addressed comments. I want to give the user feedback when the filetransfer is finished. The user might want to know if the transfer was successful even when the phone is not reachable

But we already have that information. When the job ends we can show what we please.

nicolasfella abandoned this revision.Jul 10 2017, 6:23 PM

Revision Contents
Changeset List

Diff 15453

View Options

plugins/share/kdeconnect_share.json

Loading...
View Options

plugins/share/shareplugin.h

Loading...
View Options

plugins/share/shareplugin.cpp

Loading...