I don't agree with this patch, the global menu bar should not be setting actions to invisible, why is it doing that?

I think the bug is on their side not in Okular side

In D6185#116489, @aacid wrote:

I don't agree with this patch, the global menu bar should not be setting actions to invisible, why is it doing that?

I think the bug is on their side not in Okular side

It kind of makes sense for the menu bar actions to be unavailable since the menu is no longer inside the app, but rather in the title bar or in a panel widget, so you cannot really show/hide it anymore. And by "their side" I assume you mean the team that writes KDE Libraries?

Anyhow feel free to close this if you think the bug is not related to Okular.

In D6185#116491, @emateli wrote:

In D6185#116489, @aacid wrote:

I don't agree with this patch, the global menu bar should not be setting actions to invisible, why is it doing that?

I think the bug is on their side not in Okular side

It kind of makes sense for the menu bar actions to be unavailable since the menu is no longer inside the app, but rather in the title bar or in a panel widget, so you cannot really show/hide it anymore.

Right, actually it's "visible all the time", so why are they hidden?

And by "their side" I assume you mean the team that writes KDE Libraries?

I don't think this is done in "KDE Libraries", but if it is, yes.

As far as I can tell from the source it's not Okular that it's doing the hiding of that specific action, but rather the underlying framework apparently. The action is visible again if you explicitly call setVisible(true) but as expected, it does nothing when invoked.

So even if it weren't hidden, showMenuBar action would not be working regardless since the menubar is not handled by Okular anymore. So I personally don't think that hiding or disabling it would be wrong,

Hmmm, now you're saying something that doesn't make sense to me.

I wrote the code that hides the Show Menu Bar action and it explicitily sets the action as checked https://cgit.kde.org/kconfigwidgets.git/tree/src/kstandardaction.cpp#n122

Which frameworks version are you using? And which Qt?

I can see that the source you linked explicitly makes it checked, but If you inspect the state just before the if execution you'd see that it actually is not checked. Anyhow, if KStandartAction is supposed to handle this, then I guess the bug(if any) might be there and not in Okular after all. Just try it out on your own machine with menubar style set to "title bar".

Using:

• KDE Frameworks 5.35.0
• QMake version 3.1
• Qt version 5.9.0

the bug is actually in Shell::showEvent