Differential D617

prevent "create" button in "new document" window to be clicked multiple times
ClosedPublic
Actions

Authored by tpaulssen on Nov 29 2015, 12:50 AM.

Details

Reviewers
abrahams
rempt
Commits
R37:8cf76d9b6547: prevent "create" button in "new document" window to be clicked multiple times
Summary

This prevents accidental creation of multiple images when creating the image is slower than clicking (i can easily get five images open by clicking fast). for some reason, opening multiple images like this also causes an assertion to fire:

ASSERT (krita): "m_dummiesMap.contains(node)" in file /home/timo/kde4/src/krita/krita/ui/flake/kis_node_dummies_graph.cpp, line 187

With this patch it's no longer possible to create multiple new files "in parallel"

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tpaulssen updated this revision to Diff 1424.Nov 29 2015, 12:50 AM
tpaulssen retitled this revision from to prevent "create" button in "new document" window to be clicked multiple times.
tpaulssen updated this object.
tpaulssen edited the test plan for this revision. (Show Details)
tpaulssen set the repository for this revision to R37 Krita.
tpaulssen added a project: Krita.
tpaulssen added a subscriber: rempt.Dec 3 2015, 12:42 PM

boud asked to be subscribed via IRC

abrahams accepted this revision.Dec 8 2015, 11:28 PM
abrahams edited edge metadata.

Hahaha, I got eight. Nice find, definitely need this.

This revision is now accepted and ready to land.Dec 8 2015, 11:28 PM
Closed by commit R37:8cf76d9b6547: prevent "create" button in "new document" window to be clicked multiple times (authored by tpaulssen). · Explain WhyDec 9 2015, 7:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1492

View Options

krita/ui/widgets/kis_custom_image_widget.cc

Loading...