generate the old key before updating enabledborders
ClosedPublic

Authored by mart on Jun 9 2017, 2:07 PM.

Details

Summary

sometimes a frame changed enabled borders causing a dangling
pointer in s_sharedFrames, since oldkey was generated
with the new enabled borders, it generated a key not present
in the hash, tryed to remove it and left the one associated
with the old key in the hash.
if the need to reuse a frame with that key ever arised again,
we had a crash
BUG:378508

Test Plan

couldn't reproduce the crash neither with or without patch,
with the patch, if i put debug in every place a framedata is removed,
searching if the key is in the hash before removing it, now
it's always true, before sometimes it was false

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Jun 9 2017, 2:07 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJun 9 2017, 2:07 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jun 9 2017, 2:14 PM
This revision is now accepted and ready to land.Jun 9 2017, 2:14 PM
This revision was automatically updated to reflect the committed changes.