Differential D6140

Standardize the GlobalHeader height
ClosedPublic
Actions

Authored by apol on Jun 7 2017, 3:47 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:247bd7f46a5c: Standardize the GlobalHeader height
Summary

The size becomes static rather than depending on the header image
form factor.
Makes sure it has the same height as the list headers

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jun 7 2017, 3:47 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJun 7 2017, 3:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol added a comment.Jun 7 2017, 3:50 PM

Examples

Kirigami Gallery on Material

Kirigami Gallery desktop

Discover

Klimbgrades

apol added a comment.Jun 7 2017, 3:52 PM

People with good taste: I'm wondering whether the blue thing should actually be outside rather than inside. What do you think?

mart edited edge metadata.Jun 7 2017, 5:30 PM
In D6140#114909, @apol wrote:

People with good taste: I'm wondering whether the blue thing should actually be outside rather than inside. What do you think?

inside.

mart accepted this revision.Jun 7 2017, 5:31 PM
This revision is now accepted and ready to land.Jun 7 2017, 5:31 PM
Closed by commit R169:247bd7f46a5c: Standardize the GlobalHeader height (authored by apol). · Explain WhyJun 7 2017, 5:37 PM
This revision was automatically updated to reflect the committed changes.
jensreuterberg added a subscriber: jensreuterberg.Jun 7 2017, 5:39 PM

I have to agree with Marco (inside) although I am currently wearing a striped tanktop and chequered shorts so "good taste" may not apply to me ;)

Revision Contents
Changeset List

Diff 15261

View Options

src/controls/GlobalDrawer.qml

Loading...
View Options

src/controls/ItemViewHeader.qml

Loading...