Multiplication_tables code review
Needs ReviewPublic

Authored by nitish on Jun 6 2017, 8:05 PM.

Details

Summary

Task completed :-
1.) There was no mode by default: Initialized it to "normal".
2.) Refactored the code in JS files.
3.) Used JS inbuilt functions where possible.
4.) Minor UI fixes.
5.) Removed unused variables.
6.) Added copyrights and author.
7.) Reduced number of JS functions that were unnecessary.

Pending :-
1.) Screen resizing (I have started but need little guidance)
2.) Virtual Keyboard implementation (I am planning to do it after screen resizing)

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
nitish created this revision.Jun 6 2017, 8:05 PM
nitish edited the summary of this revision. (Show Details)